Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hammer/resize #758

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Hammer/resize #758

merged 2 commits into from
Aug 31, 2023

Conversation

aaronchongth
Copy link
Member

What's new

Increase base font size across app.

Before,

image

After

image

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth
Map resized
a5c7aac 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Resized app base font size, with other components in datagrid
473bc4f 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #758 (473bc4f) into deploy/hammer (de3a5ad) will increase coverage by 0.36%.
Report is 8 commits behind head on deploy/hammer.
The diff coverage is 30.00%.

@@                Coverage Diff                @@
##           deploy/hammer     #758      +/-   ##
=================================================
+ Coverage          54.26%   54.62%   +0.36%     
=================================================
  Files                263      263              
  Lines               6583     6545      -38     
  Branches             875      866       -9     
=================================================
+ Hits                3572     3575       +3     
+ Misses              2871     2830      -41     
  Partials             140      140
Flag Coverage Δ
dashboard 18.11% <30.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/app-base.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/components/map-app.tsx 0.00% <0.00%> (ø)
...t-components/lib/beacons/beacon-table-datagrid.tsx 90.90% <ø> (ø)
...react-components/lib/doors/door-table-datagrid.tsx 74.28% <ø> (ø)
...react-components/lib/lifts/lift-table-datagrid.tsx 56.41% <ø> (ø)
...act-components/lib/robots/robot-table-datagrid.tsx 84.61% <ø> (ø)
...ackages/react-components/lib/tasks/create-task.tsx 2.78% <ø> (+0.40%) ⬆️
...ges/react-components/lib/window/window-toolbar.tsx 50.00% <ø> (ø)
packages/dashboard/src/components/appbar.tsx 30.13% <100.00%> (+0.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Angatupyry
Angatupyry approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Angatupyry
Copy link
Collaborator

I think the warning about unused variables has already been fixed in another PR. Just to keep this in mind.

@aaronchongth aaronchongth merged commit ff07f78 into deploy/hammer Aug 31, 2023
2 of 4 checks passed
@aaronchongth aaronchongth deleted the hammer/resize branch August 31, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angatupyry Angatupyry Angatupyry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchongth @Angatupyry